Skip to content

feat(storage): Add full object checksum validation for appendable uploads#16110

Open
v-pratap wants to merge 5 commits into
googleapis:mainfrom
v-pratap:fastbyte-full-object-checksum
Open

feat(storage): Add full object checksum validation for appendable uploads#16110
v-pratap wants to merge 5 commits into
googleapis:mainfrom
v-pratap:fastbyte-full-object-checksum

Conversation

@v-pratap
Copy link
Copy Markdown
Contributor

@v-pratap v-pratap commented May 21, 2026

No description provided.

@v-pratap v-pratap requested review from a team as code owners May 21, 2026 09:00
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 21, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements dynamic CRC32C validation for appendable object uploads by updating the connection and writer logic to initialize hash functions from RPC response metadata. It also adds a stateful constructor to the CRC32C hash function. Feedback highlights a critical regression where a large suite of existing integration tests was deleted and replaced with experimental code. Additional suggestions include adding defensive checks for CRC32C field presence, utilizing existing library thread management instead of a custom thread pool in tests, and using environment variables instead of hardcoded strings for test configuration.

Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
Comment thread google/cloud/storage/internal/async/connection_impl.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 91.86992% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.70%. Comparing base (3b37d40) to head (2793d61).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/storage/internal/async/writer_connection_impl.cc 55.00% 9 Missing ⚠️
...le/cloud/storage/internal/async/connection_impl.cc 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #16110    +/-   ##
========================================
  Coverage   92.70%   92.70%            
========================================
  Files        2353     2353            
  Lines      218888   219029   +141     
========================================
+ Hits       202925   203059   +134     
- Misses      15963    15970     +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@v-pratap